refactor: speed up audience mapper validation #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
January 23, 2025 10:29
Head branch was pushed to by a user without write access
sybereal
force-pushed
the
960-audience-mapper-dont-load-all-clients
branch
from
26e16c3 to
39fe68b
Compare
|
Thanks for the review. Rebased onto current main. |
|
@sybereal Can you please also sign-off your commits? |
Do not load all clients when validating client audience for audience mappers. Instead, try to fetch the client in question directly. Signed-off-by: Simon Engmann <[email protected]>
sybereal
force-pushed
the
960-audience-mapper-dont-load-all-clients
branch
from
39fe68b to
8649bd2
Compare
|
Sure, no problem. Done. |
angeloxx
pushed a commit
to angeloxx/terraform-provider-keycloak
that referenced
this pull request
Jan 26, 2025
Do not load all clients when validating client audience for audience mappers. Instead, try to fetch the client in question directly. Signed-off-by: Simon Engmann <[email protected]> Signed-off-by: angeloxx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not load all clients when validating client audience for audience mappers. Instead, try to fetch the client in question directly.
Closes #960